Fixes to work with latest deps, alternative approach.#290
Closed
pp-mo wants to merge 5 commits intoSciTools:mainfrom
Closed
Fixes to work with latest deps, alternative approach.#290pp-mo wants to merge 5 commits intoSciTools:mainfrom
pp-mo wants to merge 5 commits intoSciTools:mainfrom
Conversation
pp-mo
commented
Mar 4, 2022
| </coord> | ||
| <coord> | ||
| <dimCoord bounds="[[0.0, 100.0]]" id="c87e380b" long_name="height above ground level" points="[50.0]" shape="(1,)" standard_name="height" units="Unit('m')" value_type="float64"/> | ||
| <dimCoord bounds="[[0.0, 100.0]]" id="1a539915" long_name="height above ground level" points="[50.0]" shape="(1,)" standard_name="height" units="Unit('m')" value_type="float64"> |
Member
Author
There was a problem hiding this comment.
NOTE: these two coords remain 'float' as before (in contrast to #288),
but the id's changed because of the additional attribute.
Member
Author
|
ideas in #288, but not merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked the commits from #288, but modified all uses of cf_units
date2numto make all results floats as before, rather than fixing test results (CML files).In draft because fixing #288 is probably preferable to merging this -- there are other changes requested there, too.